zml1206 commented on code in PR #10870:
URL:
https://github.com/apache/incubator-gluten/pull/10870#discussion_r2425381959
##########
backends-velox/src/main/scala/org/apache/gluten/backendsapi/velox/VeloxMetricsApi.scala:
##########
@@ -95,7 +95,9 @@ class VeloxMetricsApi extends MetricsApi with Logging {
"numOutputRows" -> SQLMetrics.createMetric(sparkContext, "number of
output rows"),
"outputVectors" -> SQLMetrics.createMetric(sparkContext, "number of
output vectors"),
"outputBytes" -> SQLMetrics.createSizeMetric(sparkContext, "number of
output bytes"),
- "wallNanos" -> SQLMetrics.createNanoTimingMetric(sparkContext, "time of
batch scan"),
+ "wallNanos" -> SQLMetrics.createNanoTimingMetric(
+ sparkContext,
+ "time of batch scan and filter"),
Review Comment:
How about unifying them with other scans?
"time of batch scan" -> "time of scan and filter"
"scan time" -> "time of scan"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
