zhztheplayer commented on code in PR #10823:
URL: 
https://github.com/apache/incubator-gluten/pull/10823#discussion_r2393710076


##########
gluten-substrait/src/main/scala/org/apache/gluten/backendsapi/BackendSettingsApi.scala:
##########
@@ -161,4 +161,6 @@ trait BackendSettingsApi {
   def supportReplaceDataExec(): Boolean = false
 
   def supportOverwriteByExpression(): Boolean = false
+
+  def supportOverwritePartitionsDynamic(): Boolean = false

Review Comment:
   Unnecessarily related to this PR, but we do need to have the new V2 columnar 
write operators covered in tests individually without having to enable the 
Iceberg writer, as they were design to be general. Vanilla Spark uses an 
in-memory catalog for testing the row-based V2 write operators. We may want to 
introduce something similar just for testing. 
https://github.com/apache/incubator-gluten/issues/9896



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to