zhanglistar commented on code in PR #10815:
URL:
https://github.com/apache/incubator-gluten/pull/10815#discussion_r2418334102
##########
cpp-ch/local-engine/jni/jni_common.h:
##########
@@ -46,6 +47,106 @@ jstring charTojstring(JNIEnv * env, const char * pat);
jbyteArray stringTojbyteArray(JNIEnv * env, const std::string & str);
+// A watcher to monitor JNIEnv status: it's active or not
+class JniEnvStatusWatcher
Review Comment:
Better add
```
JniEnvStatusWatcher() = default;
~JniEnvStatusWatcher() = default;
```
and set to private to avoid compiler autogenerate. Same as above other
singleton class.
##########
cpp-ch/local-engine/jni/jni_common.h:
##########
@@ -46,6 +47,106 @@ jstring charTojstring(JNIEnv * env, const char * pat);
jbyteArray stringTojbyteArray(JNIEnv * env, const std::string & str);
+// A watcher to monitor JNIEnv status: it's active or not
+class JniEnvStatusWatcher
Review Comment:
Better add
```
JniEnvStatusWatcher() = default;
~JniEnvStatusWatcher() = default;
```
and set to private to avoid compiler autogenerate. Same as above other
singleton classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
