PHILO-HE commented on code in PR #10930:
URL:
https://github.com/apache/incubator-gluten/pull/10930#discussion_r2459422653
##########
dev/builddeps-veloxbe.sh:
##########
@@ -298,17 +298,17 @@ function setup_dependencies {
OS=`uname -s`
ARCH=`uname -m`
-commands_to_run=${OTHER_ARGUMENTS:-}
+commands_to_run=(${OTHER_ARGUMENTS[@]:-})
(
- if [[ "x$commands_to_run" == "x" ]]; then
+ if [[ ${#commands_to_run[@]} -eq 0 ]]; then
get_velox
if [ -z "${GLUTEN_VCPKG_ENABLED:-}" ] && [ $RUN_SETUP_SCRIPT == "ON" ];
then
setup_dependencies
fi
build_velox_backend
else
- echo "Commands to run: $commands_to_run"
- for cmd in "$commands_to_run"; do
Review Comment:
It seems we can also fix it by removing the quote mark as follows:
`for cmd in $commands_to_run; do`
They are both good to me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
