wForget commented on code in PR #10942:
URL:
https://github.com/apache/incubator-gluten/pull/10942#discussion_r2464977686
##########
backends-velox/src-delta/main/scala/org/apache/gluten/component/VeloxDeltaComponent.scala:
##########
@@ -25,12 +25,24 @@ import
org.apache.gluten.extension.columnar.validator.Validators
import org.apache.gluten.extension.injector.Injector
import org.apache.spark.sql.execution.{FileSourceScanExec, FilterExec,
ProjectExec}
+import org.apache.spark.util.SparkReflectionUtil
class VeloxDeltaComponent extends Component {
override def name(): String = "velox-delta"
override def buildInfo(): Component.BuildInfo =
Component.BuildInfo("VeloxDelta", "N/A", "N/A", "N/A")
override def dependencies(): Seq[Class[_ <: Component]] =
classOf[VeloxBackend] :: Nil
+
+ override def isRuntimeCompatible: Boolean = {
+ try {
+
SparkReflectionUtil.classForName("io.delta.sql.DeltaSparkSessionExtension")
+ true
+ } catch {
+ case _: ClassNotFoundException =>
+ false
Review Comment:
Should we fail fast or add some warn logs?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
