zml1206 commented on code in PR #10951:
URL:
https://github.com/apache/incubator-gluten/pull/10951#discussion_r2467710600
##########
backends-velox/src/main/scala/org/apache/gluten/backendsapi/velox/VeloxTransformerApi.scala:
##########
@@ -69,7 +70,13 @@ class VeloxTransformerApi extends TransformerApi with
Logging {
override def postProcessNativeConfig(
nativeConfMap: JMap[String, String],
backendPrefix: String): Unit = {
- // TODO: IMPLEMENT SPECIAL PROCESS FOR VELOX BACKEND
+ // 'spark.hadoop.fs.s3a.connection.timeout' by velox requires time unit,
hadoop-aws versions
+ // before 3.4 do not have time units.
+ val s3sConnectionTimeout =
+ nativeConfMap.getOrDefault("spark.hadoop.fs.s3a.connection.timeout",
"200000")
Review Comment:
I think it is OK to add or not add the default value, because hadoop-aws has
a default value.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
