PHILO-HE commented on code in PR #10935:
URL:
https://github.com/apache/incubator-gluten/pull/10935#discussion_r2468209379
##########
ep/build-velox/src/setup-rhel.sh:
##########
@@ -312,27 +194,64 @@ function install_rapidjson {
}
function install_c-ares {
- github_checkout c-ares/c-ares v1.34 --depth 1
- cmake_install -DCMAKE_BUILD_TYPE=Release
+ wget_and_untar
https://github.com/c-ares/c-ares/archive/refs/tags/${C_ARES_VERSION}.tar.gz
c-ares
+ cmake_install_dir c-ares -DCMAKE_BUILD_TYPE=Release
}
-function install_cuda {
- # See https://developer.nvidia.com/cuda-downloads
- dnf config-manager --add-repo
https://developer.download.nvidia.com/compute/cuda/repos/rhel9/x86_64/cuda-rhel9.repo
- local dashed="$(echo $1 | tr '.' '-')"
- dnf install -y cuda-nvcc-$dashed cuda-cudart-devel-$dashed
cuda-nvrtc-devel-$dashed cuda-driver-devel-$dashed
+function install_arrow {
Review Comment:
I think we should remove `install_arrow`. Currently, Gluten's script
`build-arrow.sh` is used to build and install arrow libs for Gluten and Velox
to use, with some patches applied and custom build options used.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
