zhztheplayer commented on code in PR #10934: URL: https://github.com/apache/incubator-gluten/pull/10934#discussion_r2473353040
########## cpp/velox/cudf/GpuLock.cc: ########## @@ -0,0 +1,64 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +#include "GpuLock.h" +#include <mutex> +#include <condition_variable> +#include <optional> +#include <stdexcept> + +namespace gluten { + +static std::mutex gGpuMutex; +static std::condition_variable gGpuCv; +static std::optional<std::thread::id> gGpuOwner; Review Comment: ```suggestion namespace { struct GpuLockState { std::mutex gGpuMutex; std::condition_variable gGpuCv; std::optional<std::thread::id> gGpuOwner; }; GpuLockState& getGpuLockState() { static GpuLockState gGpuLockState; return gGpuLockState; } } ``` I would suggest the above change because I used to encounter some SIOF issues with similar global static variable code in the past. Construct-on-First-Use can definitely prevent the risk of wrong initialization order. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
