jinchengchenghh commented on code in PR #10934:
URL:
https://github.com/apache/incubator-gluten/pull/10934#discussion_r2478565177
##########
backends-clickhouse/src/main/scala/org/apache/gluten/backendsapi/clickhouse/CHSparkPlanExecApi.scala:
##########
@@ -454,7 +454,8 @@ class CHSparkPlanExecApi extends SparkPlanExecApi with
Logging {
override def createColumnarBatchSerializer(
schema: StructType,
metrics: Map[String, SQLMetric],
- shuffleWriterType: ShuffleWriterType): Serializer = {
+ shuffleWriterType: ShuffleWriterType,
+ enableCudf: Boolean): Serializer = {
Review Comment:
Make sense, and I notice the shuffle writer type name exists in cpp and
scala code, should we use protobuf for them?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
