PHILO-HE commented on PR #10958: URL: https://github.com/apache/incubator-gluten/pull/10958#issuecomment-3471093078
@FelixYBW, I feel that using sed command may cause unintentional replacement issue. I just investigated Velox. It uses clang-tidy to check code style based on a configuration file, where we can set to replace NULL with nullptr, see https://github.com/facebookincubator/velox/blob/8a5a520fba06ab1fc10f124f3eb000bab886cd5d/.clang-tidy#L102. If this sounds good to you, I can help enable clang-tidy in another PR. It can also cover some other code styles checks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
