PHILO-HE commented on code in PR #10993:
URL:
https://github.com/apache/incubator-gluten/pull/10993#discussion_r2485747499
##########
dev/docker/Dockerfile.cent7-gcc13:
##########
Review Comment:
ditto
##########
dev/docker/Dockerfile.cent8-gcc13:
##########
Review Comment:
Should we name it `Dockerfile.centos8-gcc13` for consistency?
##########
dev/vcpkg/triplets/x64-linux-avx.cmake:
##########
@@ -8,3 +8,7 @@ set(VCPKG_CMAKE_SYSTEM_NAME Linux)
set(VCPKG_C_FLAGS "-mavx2 -mfma -mavx -mf16c -mlzcnt -mbmi2")
set(VCPKG_CXX_FLAGS "-mavx2 -mfma -mavx -mf16c -mlzcnt -std=c++17 -mbmi2")
set(VCPKG_LINKER_FLAGS "-static-libstdc++ -static-libgcc")
+
+if("${PORT}" STREQUAL "snappy")
+ list(APPEND VCPKG_CMAKE_CONFIGURE_OPTIONS -DSNAPPY_HAVE_BMI2=ON)
+endif()
Review Comment:
nit: please leave an empty at the end.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
