jinchengchenghh commented on code in PR #4177:
URL: https://github.com/apache/incubator-gluten/pull/4177#discussion_r2491637131
##########
cpp/velox/substrait/SubstraitToVeloxPlan.cc:
##########
@@ -960,6 +960,36 @@ core::PlanNodePtr
SubstraitToVeloxPlanConverter::toVeloxPlan(const ::substrait::
}
}
+core::PlanNodePtr SubstraitToVeloxPlanConverter::constructValueStreamNode(
+ const ::substrait::ReadRel& readRel,
+ int32_t streamIdx) {
+ // Get the input schema of this iterator.
+ uint64_t colNum = 0;
+ std::vector<TypePtr> veloxTypeList;
+ if (readRel.has_base_schema()) {
Review Comment:
I find here you change the input iterator names, and comment ValueStreamNode
in Velox does not support name change, but here updates the output type based
on output type, do you meet any problem? @Yohahaha
https://github.com/apache/incubator-gluten/blob/c5b7e59335201f960cda49dff7edc315b36ed05e/cpp/velox/operators/plannodes/RowVectorStream.h#L100
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
