FelixYBW commented on code in PR #11024: URL: https://github.com/apache/incubator-gluten/pull/11024#discussion_r2492546263
########## cpp/velox/compute/WholeStageResultIterator.cc: ########## @@ -54,6 +54,7 @@ const std::string kRamReadBytes = "ramReadBytes"; const std::string kPreloadSplits = "readyPreloadedSplits"; const std::string kPageLoadTime = "pageLoadTimeNs"; const std::string kDataSourceAddSplitWallNanos = "dataSourceAddSplitWallNanos"; Review Comment: Can you rename to ########## cpp/velox/compute/WholeStageResultIterator.cc: ########## @@ -54,6 +54,7 @@ const std::string kRamReadBytes = "ramReadBytes"; const std::string kPreloadSplits = "readyPreloadedSplits"; const std::string kPageLoadTime = "pageLoadTimeNs"; const std::string kDataSourceAddSplitWallNanos = "dataSourceAddSplitWallNanos"; Review Comment: Can you rename to -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
