PHILO-HE commented on code in PR #11022:
URL:
https://github.com/apache/incubator-gluten/pull/11022#discussion_r2493299995
##########
.github/workflows/velox_backend_enhanced.yml:
##########
@@ -95,9 +106,9 @@ jobs:
if-no-files-found: error
spark-test-spark34:
- needs: build-native-lib-centos-7
+ needs: [build-native-lib-centos-7, setup-image-prefix-for-test]
runs-on: ubuntu-22.04
- container: apache/gluten:centos-8-jdk8
+ container: ${{
needs.setup-image-prefix-for-test.outputs.image_tag_prefix_dynamic }}-8-jdk8
Review Comment:
@zhouyuan Could you explain the benefit of introducing
`setup-image-prefix-for-test`?
I feel it may be good enough for us by declaring environment variables at
the beginning of each workflow, like
```
DOCKER_IMAGE_FOR_BUILD: 'apache/gluten:vcpkg-centos-7'
DOCKER_IMAGE_FOR_TEST: 'apache/gluten:centos-8'
```
Then, we can use these env arg to specify the docker image for running jobs.
We can also flexibly specify some other public images (e.g. ubuntu:20.04) in
the job section.
For branch development, we can directly change these environment variables
to use images specific to a branch.
Please let me know if I missed anything.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
