liujiayi771 commented on code in PR #11040: URL: https://github.com/apache/incubator-gluten/pull/11040#discussion_r2509241354
########## backends-velox/src/main/scala/org/apache/gluten/execution/HashAggregateExecTransformer.scala: ########## @@ -272,13 +265,12 @@ abstract class HashAggregateExecTransformer( // Add a projection node before aggregation for row constructing. // Mainly used for aggregation whose intermediate type is a compound type in Velox. // Pre-projection is always not required for final stage. Review Comment: @PHILO-HE Yes. Final aggregation does not require pre-projection. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
