PHILO-HE commented on code in PR #11064:
URL:
https://github.com/apache/incubator-gluten/pull/11064#discussion_r2517209695
##########
.github/workflows/docker_image.yml:
##########
@@ -385,10 +385,10 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
- digests: [ vcpkg-centos-8, vcpkg-centos-8-gcc13, vcpkg-centos-9,
centos-8-jdk8, centos-8-jdk11, centos-8-jdk17, centos-9-jdk8, centos-9-jdk11,
centos-9-jdk17 ]
+ digests: [ vcpkg-centos-8, vcpkg-centos-8_gcc13, vcpkg-centos-9,
centos-8-jdk8, centos-8-jdk11, centos-8-jdk17, centos-9-jdk8, centos-9-jdk11,
centos-9-jdk17 ]
Review Comment:
How about creating a separate merge job for gcc13 dockers? Then, no impact
due to the name pattern conflict.
I feel it may be better to keep the naming consistency with hyphen as
separator.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
