wForget commented on code in PR #11113:
URL:
https://github.com/apache/incubator-gluten/pull/11113#discussion_r2540265386
##########
gluten-substrait/src/main/scala/org/apache/gluten/execution/FileSourceScanExecTransformer.scala:
##########
@@ -123,8 +123,8 @@ abstract class FileSourceScanExecTransformerBase(
override def getMetadataColumns(): Seq[AttributeReference] = metadataColumns
- override def getPartitions: Seq[Partition] = {
- BackendsApiManager.getTransformerApiInstance
+ override def getPartitions: Seq[(Seq[Partition], ReadFileFormat)] = {
Review Comment:
Would it be better to add a new implementation of Partition with
ReadFileFormat? That would make it easier for us to extend partition with
schema in the future.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
