FelixYBW commented on PR #11101: URL: https://github.com/apache/incubator-gluten/pull/11101#issuecomment-3551752093
Thank for the fix. Can you add a comment to header file and comment pageNumber_ 13bit pageCursor_ 27bit row2Partition_ vector of 24bit We may need to check the overflow of all 3 values and add an assert in toCompactRowId before convert. @marin-ma https://github.com/apache/incubator-gluten/blob/b94323749df31d107ca4a7facd73e53364af5290/cpp/velox/shuffle/VeloxSortShuffleWriter.h#L109 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
