jinchengchenghh commented on code in PR #11127:
URL:
https://github.com/apache/incubator-gluten/pull/11127#discussion_r2545476663
##########
cpp/core/operators/serializer/ColumnarBatchSerializer.h:
##########
@@ -29,8 +29,11 @@ class ColumnarBatchSerializer {
virtual ~ColumnarBatchSerializer() = default;
- virtual std::shared_ptr<arrow::Buffer> serializeColumnarBatches(
- const std::vector<std::shared_ptr<ColumnarBatch>>& batches) = 0;
+ virtual void addForSerialization(const std::shared_ptr<ColumnarBatch>&
batch) = 0;
Review Comment:
This function calls Velox function append, so I would prefer function name
`append`
##########
cpp/core/operators/serializer/ColumnarBatchSerializer.h:
##########
@@ -29,8 +29,11 @@ class ColumnarBatchSerializer {
virtual ~ColumnarBatchSerializer() = default;
- virtual std::shared_ptr<arrow::Buffer> serializeColumnarBatches(
- const std::vector<std::shared_ptr<ColumnarBatch>>& batches) = 0;
+ virtual void addForSerialization(const std::shared_ptr<ColumnarBatch>&
batch) = 0;
+
+ virtual int64_t serializedSize() = 0;
Review Comment:
same maxSerializedSize
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
