PHILO-HE commented on code in PR #10939:
URL:
https://github.com/apache/incubator-gluten/pull/10939#discussion_r2546155350
##########
backends-velox/src/main/scala/org/apache/gluten/execution/GenerateExecTransformer.scala:
##########
@@ -243,15 +242,15 @@ object PullOutGenerateProjectHelper extends
PullOutProjectHelper {
case jsonPath if jsonPath.foldable =>
Option(jsonPath.eval()) match {
case Some(path) =>
- GetJsonObject(jsonObj, Literal.create(JSON_PATH_PREFIX +
path))
+ GetJsonObject(jsonObj, Literal.create("$[" + path + "]"))
case _ =>
Literal.create(null)
}
case jsonPath =>
- // TODO: The prefix is just for adapting to GetJsonObject.
- // Maybe, we can remove this handling in the future by
- // making path without "$." recognized
- GetJsonObject(jsonObj,
Concat(Seq(Literal.create(JSON_PATH_PREFIX), jsonPath)))
+ // Build bracket-notation uniformly to support nested paths,
e.g., $[a.b]
Review Comment:
I think it doesn't mean nested path, but just the field name containing dot.
Suggestion:
Build bracket notation uniformly to allow dot-containing field names in JSON
paths, e.g., $[a.b]".
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
