This is an automated email from the ASF dual-hosted git repository.
philo pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/incubator-gluten.git
The following commit(s) were added to refs/heads/main by this push:
new a7cb7fe1e5 [VL] Suppress "uninitialized" warnings treated as errors in
GCC 13 builds (#11118)
a7cb7fe1e5 is described below
commit a7cb7fe1e54da9a9611b7537b2d5a7da848c5f43
Author: PHILO-HE <[email protected]>
AuthorDate: Fri Nov 21 13:26:23 2025 +0800
[VL] Suppress "uninitialized" warnings treated as errors in GCC 13 builds
(#11118)
---
cpp/CMakeLists.txt | 3 +++
ep/build-velox/src/build-velox.sh | 15 ++++++++++-----
2 files changed, 13 insertions(+), 5 deletions(-)
diff --git a/cpp/CMakeLists.txt b/cpp/CMakeLists.txt
index 923ef2751d..efb0e1a3d2 100644
--- a/cpp/CMakeLists.txt
+++ b/cpp/CMakeLists.txt
@@ -98,6 +98,9 @@ set(KNOWN_WARNINGS
-Wno-error=parentheses \
-Wno-error=unused-function \
-Wno-error=unused-variable \
+ -Wno-error=uninitialized \
+ -Wno-error=maybe-uninitialized \
+ -Wno-unknown-warning-option \
-Wno-strict-aliasing \
-Wno-ignored-qualifiers \
-Wno-deprecated-declarations \
diff --git a/ep/build-velox/src/build-velox.sh
b/ep/build-velox/src/build-velox.sh
index e83b2cdda8..3e0f6be4fb 100755
--- a/ep/build-velox/src/build-velox.sh
+++ b/ep/build-velox/src/build-velox.sh
@@ -98,11 +98,15 @@ for arg in "$@"; do
done
function compile {
- # Maybe there is some set option in velox setup script. Run set command
again.
- set -exu
+ # -Wno-unknown-warning-option is a Clang-originated flag. GCC ignores
unrecognized -Wno- flags to
+ # maintain compatibility, but it prints a diagnostic note about the unknown
flag if a true warning
+ # or error occurs.
+ CXX_FLAGS='-Wno-error=stringop-overflow -Wno-error=cpp
-Wno-missing-field-initializers \
+ -Wno-error=uninitialized -Wno-unknown-warning-option'
- CXX_FLAGS='-Wno-error=stringop-overflow -Wno-error=cpp
-Wno-missing-field-initializers -Wno-unknown-warning-option'
- COMPILE_OPTION="-DCMAKE_CXX_FLAGS=\"$CXX_FLAGS\" -DVELOX_ENABLE_PARQUET=ON
-DVELOX_BUILD_TESTING=OFF -DVELOX_MONO_LIBRARY=ON -DVELOX_BUILD_RUNNER=OFF
-DVELOX_SIMDJSON_SKIPUTF8VALIDATION=ON -DVELOX_ENABLE_GEO=ON"
+ COMPILE_OPTION="-DCMAKE_CXX_FLAGS=\"$CXX_FLAGS\" -DVELOX_ENABLE_PARQUET=ON
-DVELOX_BUILD_TESTING=OFF \
+ -DVELOX_MONO_LIBRARY=ON -DVELOX_BUILD_RUNNER=OFF
-DVELOX_SIMDJSON_SKIPUTF8VALIDATION=ON \
+ -DVELOX_ENABLE_GEO=ON"
if [ $BUILD_TEST_UTILS == "ON" ]; then
COMPILE_OPTION="$COMPILE_OPTION -DVELOX_BUILD_TEST_UTILS=ON"
fi
@@ -130,7 +134,8 @@ function compile {
if [ $ENABLE_GPU == "ON" ]; then
# the cuda default options are for Centos9 image from Meta
echo "enable GPU support."
- COMPILE_OPTION="$COMPILE_OPTION -DVELOX_ENABLE_GPU=ON
-DVELOX_ENABLE_CUDF=ON -DCMAKE_CUDA_ARCHITECTURES=70
-DCMAKE_CUDA_COMPILER=/usr/local/cuda-12.8/bin/nvcc"
+ COMPILE_OPTION="$COMPILE_OPTION -DVELOX_ENABLE_GPU=ON
-DVELOX_ENABLE_CUDF=ON -DCMAKE_CUDA_ARCHITECTURES=70 \
+ -DCMAKE_CUDA_COMPILER=/usr/local/cuda-12.8/bin/nvcc"
fi
if [ -n "${GLUTEN_VCPKG_ENABLED:-}" ]; then
COMPILE_OPTION="$COMPILE_OPTION -DVELOX_GFLAGS_TYPE=static"
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
