beliefer commented on code in PR #11156:
URL:
https://github.com/apache/incubator-gluten/pull/11156#discussion_r2556359364
##########
gluten-substrait/src/main/java/org/apache/gluten/substrait/rel/RelBuilder.java:
##########
@@ -148,8 +148,8 @@ public static RelNode makeAggregateRel(
public static RelNode makeReadRel(
List<TypeNode> types,
List<String> names,
- List<ColumnTypeNode> columnTypeNodes,
ExpressionNode filter,
+ List<ColumnTypeNode> columnTypeNodes,
Review Comment:
Make the order of construct object consistent with parameters. This can help
improve readability.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
