marin-ma commented on code in PR #11181:
URL:
https://github.com/apache/incubator-gluten/pull/11181#discussion_r2560933473
##########
gluten-ut/spark40/src/test/scala/org/apache/spark/sql/catalyst/expressions/GlutenCastSuite.scala:
##########
@@ -288,4 +288,26 @@ class GlutenCastSuite extends CastWithAnsiOffSuite with
GlutenTestsTrait {
checkEvaluation(cast(d, TimestampType), new Timestamp(c.getTimeInMillis))
}
+ testGluten("Casting to char/varchar") {
+ withSQLConf(SQLConf.PRESERVE_CHAR_VARCHAR_TYPE_INFO.key -> "true") {
Review Comment:
If false, then exception will be thrown in Spark. We need to add this into
the Gluten test because it overrides the `checkEvaluation` that invokes Spark's
RowEncoder, which requires this configuration to be set. But in Vanilla spark,
the `checkEvaluation` method doesn't invoke RowEncoder.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
