zhztheplayer commented on code in PR #11176:
URL:
https://github.com/apache/incubator-gluten/pull/11176#discussion_r2564298903
##########
shims/common/src/main/scala/org/apache/gluten/sql/shims/SparkShims.scala:
##########
@@ -233,7 +233,13 @@ trait SparkShims {
def generateMetadataColumns(
file: PartitionedFile,
- metadataColumnNames: Seq[String] = Seq.empty): JMap[String, String]
+ metadataColumnNames: Seq[String] = Seq.empty): JMap[String, String] = {
+ val metadataColumn = new JHashMap[String, String]()
Review Comment:
nit: `val metadataColumn = mutable.Map[String, String]()` or `val
metadataColumn = Map[String, String](...)`, then return
`metadataColumn.asJava`, this way felt better to me as it's pure Scala code in
this function.
But I am OK to both since it's only a nit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
