jinchengchenghh commented on code in PR #11184:
URL:
https://github.com/apache/incubator-gluten/pull/11184#discussion_r2568154282
##########
shims/spark40/src/main/scala/org/apache/gluten/sql/shims/spark40/Spark40Shims.scala:
##########
@@ -481,10 +481,9 @@ class Spark40Shims extends SparkShims {
applyPartialClustering: Boolean,
replicatePartitions: Boolean,
joinKeyPositions: Option[Seq[Int]] = None): Seq[Seq[InputPartition]] = {
+ val original = batchScan.asInstanceOf[BatchScanExecShim]
Review Comment:
Could you help do a refactor for the orderPartitions function, this is
mostly copied from BatchScanExec::inputRDD, and inputPartitionsShim may can be
replaced by inputPartitions @beliefer Thanks!
https://github.com/apache/incubator-gluten/blob/49389cd05ea07356f71bfdfe660410604c1461ea/shims/spark40/src/main/scala/org/apache/spark/sql/execution/datasources/v2/AbstractBatchScanExec.scala#L60
https://github.com/apache/incubator-gluten/blob/d636fa77c49e991eb02159a0c25431eb499c6da2/shims/spark40/src/main/scala/org/apache/spark/sql/execution/datasources/v2/AbstractBatchScanExec.scala#L142
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
