zhztheplayer commented on code in PR #11222:
URL:
https://github.com/apache/incubator-gluten/pull/11222#discussion_r2571514939
##########
backends-velox/src/main/scala/org/apache/gluten/backendsapi/velox/VeloxIteratorApi.scala:
##########
@@ -145,10 +146,10 @@ class VeloxIteratorApi extends IteratorApi with Logging {
private def getPartitionColumns(
schema: StructType,
- partitionedFiles: Seq[PartitionedFile]): Seq[JMap[String, String]] = {
+ partitionedFiles: Seq[PartitionedFile]): Seq[mutable.Map[String,
String]] = {
Review Comment:
If no further write operations on the Map, can we just return
Seq[Map[String, String]]?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
