jinchengchenghh commented on code in PR #11212:
URL:
https://github.com/apache/incubator-gluten/pull/11212#discussion_r2572118828
##########
gluten-substrait/src/main/scala/org/apache/gluten/execution/BasicPhysicalOperatorTransformer.scala:
##########
@@ -313,7 +313,8 @@ object FilterHandler extends PredicateHelper {
}
def subtractFilters(left: Seq[Expression], right: Seq[Expression]):
Seq[Expression] = {
- (left.toSet -- right.toSet).toSeq
+ val scanSet = left.map(_.canonicalized).toSet
Review Comment:
Hi, I find it causes ReuseExchange issue, I find you add combineFilters, do
you have any suggestions for that, I think it may meet the same issue @Zouxxyy
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
