Yohahaha commented on code in PR #11083:
URL:
https://github.com/apache/incubator-gluten/pull/11083#discussion_r2579422668
##########
cpp/core/shuffle/ShuffleWriter.cc:
##########
@@ -61,8 +61,8 @@ int32_t ShuffleWriter::numPartitions() const {
return numPartitions_;
}
-int64_t ShuffleWriter::totalBytesWritten() const {
- return metrics_.totalBytesWritten;
+int64_t ShuffleWriter::bytesWritten() const {
Review Comment:
> Can we simply modify the signature ofShuffleWriter::write and
ShuffleWriter::stop to return the bytes evicted as Result<int64_t>
The write api can be easily modified, but the stop api is not, stop api
collect and return whole shuffle metrics of task, I prefer do refactor work for
api change in another pr and make current pr as simple as possible.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
