zhouyuan commented on code in PR #11134:
URL:
https://github.com/apache/incubator-gluten/pull/11134#discussion_r2589694555
##########
cpp/velox/compute/WholeStageResultIterator.cc:
##########
@@ -617,7 +617,7 @@ std::unordered_map<std::string, std::string>
WholeStageResultIterator::getQueryC
configs[velox::core::QueryConfig::kAbandonBuildNoDupHashMinRows] =
std::to_string(veloxCfg_->get<int32_t>(kAbandonBuildNoDupHashMinRows,
100000));
configs[velox::core::QueryConfig::kAbandonBuildNoDupHashMinPct] =
- std::to_string(veloxCfg_->get<int32_t>(kAbandonBuildNoDupHashMinPct,
0));
+
std::to_string(static_cast<int32_t>(veloxCfg_->get<double>(kAbandonBuildNoDupHashMinPct,
0)));
Review Comment:
it's mostly due the config name has a `percentile` so we change that to
double based config when enable this feature. I have modified to use int based
and update the comments
##########
cpp/velox/compute/WholeStageResultIterator.cc:
##########
@@ -617,7 +617,7 @@ std::unordered_map<std::string, std::string>
WholeStageResultIterator::getQueryC
configs[velox::core::QueryConfig::kAbandonBuildNoDupHashMinRows] =
std::to_string(veloxCfg_->get<int32_t>(kAbandonBuildNoDupHashMinRows,
100000));
configs[velox::core::QueryConfig::kAbandonBuildNoDupHashMinPct] =
- std::to_string(veloxCfg_->get<int32_t>(kAbandonBuildNoDupHashMinPct,
0));
+
std::to_string(static_cast<int32_t>(veloxCfg_->get<double>(kAbandonBuildNoDupHashMinPct,
0)));
Review Comment:
it's mostly due to the config name has a `percentile` so we change that to
double based config when enable this feature. I have modified to use int based
and update the comments
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
