bdice commented on code in PR #11275:
URL:
https://github.com/apache/incubator-gluten/pull/11275#discussion_r2608485639
##########
cpp/velox/CMakeLists.txt:
##########
@@ -439,6 +439,7 @@ if(ENABLE_GPU)
${VELOX_BUILD_PATH}/_deps/nvtx3-src/c/include
${VELOX_BUILD_PATH}/_deps/nvcomp_proprietary_binary-src/include
${VELOX_BUILD_PATH}/_deps/rapids_logger-src/include
+ /usr/local/cuda/include/cccl
Review Comment:
If possible, we should try to fix this by calling `find_package` for cudf.
It should set up all these include paths. I'll try to repro this locally with
@karthikeyann and make a suggestion.
We don't want to require a specific CUDA version just to get a particular
CCCL version -- those don't always move in lockstep and sometimes RAPIDS
requires CCCL versions that have been publicly released but are not yet shipped
in a CUDA toolkit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
