This is an automated email from the ASF dual-hosted git repository.
marong pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/incubator-gluten.git
The following commit(s) were added to refs/heads/main by this push:
new f4b2050662 [VL] Remove unused parameters in shuffle reader (#11285)
f4b2050662 is described below
commit f4b2050662e4434ecc856b1c86486ed0a139b70a
Author: xinghuayu007 <[email protected]>
AuthorDate: Sun Dec 14 12:42:14 2025 +0800
[VL] Remove unused parameters in shuffle reader (#11285)
---
cpp/velox/shuffle/VeloxShuffleReader.cc | 9 ---------
cpp/velox/shuffle/VeloxShuffleReader.h | 8 --------
2 files changed, 17 deletions(-)
diff --git a/cpp/velox/shuffle/VeloxShuffleReader.cc
b/cpp/velox/shuffle/VeloxShuffleReader.cc
index a352e63fb0..bfe11ef3e9 100644
--- a/cpp/velox/shuffle/VeloxShuffleReader.cc
+++ b/cpp/velox/shuffle/VeloxShuffleReader.cc
@@ -444,22 +444,16 @@
VeloxHashShuffleReaderDeserializer::VeloxHashShuffleReaderDeserializer(
const std::shared_ptr<arrow::Schema>& schema,
const std::shared_ptr<arrow::util::Codec>& codec,
const facebook::velox::RowTypePtr& rowType,
- int32_t batchSize,
int64_t readerBufferSize,
VeloxMemoryManager* memoryManager,
- std::vector<bool>* isValidityBuffer,
- bool hasComplexType,
int64_t& deserializeTime,
int64_t& decompressTime)
: streamReader_(streamReader),
schema_(schema),
codec_(codec),
rowType_(rowType),
- batchSize_(batchSize),
readerBufferSize_(readerBufferSize),
memoryManager_(memoryManager),
- isValidityBuffer_(isValidityBuffer),
- hasComplexType_(hasComplexType),
deserializeTime_(deserializeTime),
decompressTime_(decompressTime) {}
@@ -838,11 +832,8 @@ std::unique_ptr<ColumnarBatchIterator>
VeloxShuffleReaderDeserializerFactory::cr
schema_,
codec_,
rowType_,
- batchSize_,
readerBufferSize_,
memoryManager_,
- &isValidityBuffer_,
- hasComplexType_,
deserializeTime_,
decompressTime_);
case ShuffleWriterType::kSortShuffle:
diff --git a/cpp/velox/shuffle/VeloxShuffleReader.h
b/cpp/velox/shuffle/VeloxShuffleReader.h
index 26a1634f4d..f30595dde4 100644
--- a/cpp/velox/shuffle/VeloxShuffleReader.h
+++ b/cpp/velox/shuffle/VeloxShuffleReader.h
@@ -34,11 +34,8 @@ class VeloxHashShuffleReaderDeserializer final : public
ColumnarBatchIterator {
const std::shared_ptr<arrow::Schema>& schema,
const std::shared_ptr<arrow::util::Codec>& codec,
const facebook::velox::RowTypePtr& rowType,
- int32_t batchSize,
int64_t readerBufferSize,
VeloxMemoryManager* memoryManager,
- std::vector<bool>* isValidityBuffer,
- bool hasComplexType,
int64_t& deserializeTime,
int64_t& decompressTime);
@@ -53,20 +50,15 @@ class VeloxHashShuffleReaderDeserializer final : public
ColumnarBatchIterator {
std::shared_ptr<arrow::Schema> schema_;
std::shared_ptr<arrow::util::Codec> codec_;
facebook::velox::RowTypePtr rowType_;
- int32_t batchSize_;
int64_t readerBufferSize_;
VeloxMemoryManager* memoryManager_;
- std::vector<bool>* isValidityBuffer_;
- bool hasComplexType_;
-
int64_t& deserializeTime_;
int64_t& decompressTime_;
std::shared_ptr<arrow::io::InputStream> in_{nullptr};
bool reachedEos_{false};
- bool blockTypeResolved_{false};
std::vector<int32_t> dictionaryFields_{};
std::vector<facebook::velox::VectorPtr> dictionaries_{};
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
