zhouyuan commented on PR #11136: URL: https://github.com/apache/incubator-gluten/pull/11136#issuecomment-3680316356
The SQL query test is specially handled: we need to modify the sql outputs to align with spark for some cases. In the same time there are also updates from spark4.0 so we need to merge the modifications ________________________________ From: Jin Chengcheng ***@***.***> Sent: Monday, December 22, 2025 10:11:53 AM To: apache/incubator-gluten ***@***.***> Cc: Yuan ***@***.***>; Author ***@***.***> Subject: Re: [apache/incubator-gluten] [GLUTEN-11088][VL] Adding SQLQueryTestSuite for Spark-4.0 (PR #11136) @jinchengchenghh commented on this pull request. ________________________________ In gluten-ut/spark40/src/test/resources/backends-velox/sql-tests/inputs/binary.sql<https://github.com/apache/incubator-gluten/pull/11136#discussion_r2638398078>: > @@ -0,0 +1,8 @@ +--SET spark.sql.binaryOutputStyle=UTF-8 + +SELECT X''; Could we not copy so many files from Spark, can we use spark.test.home? — Reply to this email directly, view it on GitHub<https://github.com/apache/incubator-gluten/pull/11136#pullrequestreview-3602327931>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AAAKXDNZIOH66J2BJU3OOY34C5HOTAVCNFSM6AAAAACMXC6CBWVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZTMMBSGMZDOOJTGE>. You are receiving this because you authored the thread.Message ID: ***@***.***> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
