zml1206 commented on code in PR #11329:
URL:
https://github.com/apache/incubator-gluten/pull/11329#discussion_r2647483101
##########
backends-velox/src/main/scala/org/apache/gluten/backendsapi/velox/VeloxTransformerApi.scala:
##########
@@ -70,12 +70,20 @@ class VeloxTransformerApi extends TransformerApi with
Logging {
override def postProcessNativeConfig(
nativeConfMap: JMap[String, String],
backendPrefix: String): Unit = {
- // 'spark.hadoop.fs.s3a.connection.timeout' by velox requires time unit,
hadoop-aws versions
+ // 'spark.hadoop.fs.s3a.connection.timeout' and
'spark.hadoop.fs.s3a.connection.establish.timeout'
+ // by velox requires time unit, hadoop-aws versions
// before 3.4 do not have time unit.
val s3sConnectionTimeout =
nativeConfMap.get("spark.hadoop.fs.s3a.connection.timeout")
if (NumberUtils.isCreatable(s3sConnectionTimeout)) {
nativeConfMap.put("spark.hadoop.fs.s3a.connection.timeout",
s"${s3sConnectionTimeout}ms")
}
+ val s3sConnectionEstablishTimeout =
+ nativeConfMap.get("spark.hadoop.fs.s3a.connection.establish.timeout")
+ if (NumberUtils.isCreatable(s3sConnectionEstablishTimeout)) {
+ nativeConfMap.put(
+ "spark.hadoop.fs.s3a.connection.establish.timeout",
+ s"${s3sConnectionEstablishTimeout}ms")
+ }
Review Comment:
Use a list to store the config and unit, and then iterate through the list
to avoid duplicate code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
