This is an automated email from the ASF dual-hosted git repository. changchen pushed a commit to branch feature/41 in repository https://gitbox.apache.org/repos/asf/incubator-gluten.git
commit 9c25d2814e68853790cd3a20f72b515f712d221b Author: Chang chen <[email protected]> AuthorDate: Thu Dec 4 01:55:08 2025 +0000 [Draft] Remove TimeAdd from ExpressionConverter and ExpressionMappings for test see https://github.com/apache/spark/pull/51302 --- .../scala/org/apache/gluten/expression/ExpressionConverter.scala | 7 ------- .../scala/org/apache/gluten/expression/ExpressionMappings.scala | 1 - 2 files changed, 8 deletions(-) diff --git a/gluten-substrait/src/main/scala/org/apache/gluten/expression/ExpressionConverter.scala b/gluten-substrait/src/main/scala/org/apache/gluten/expression/ExpressionConverter.scala index 52f6d31d1d..418de8578f 100644 --- a/gluten-substrait/src/main/scala/org/apache/gluten/expression/ExpressionConverter.scala +++ b/gluten-substrait/src/main/scala/org/apache/gluten/expression/ExpressionConverter.scala @@ -856,13 +856,6 @@ object ExpressionConverter extends SQLConfHelper with Logging { dateAdd.children, dateAdd ) - case timeAdd: TimeAdd => - BackendsApiManager.getSparkPlanExecApiInstance.genDateAddTransformer( - attributeSeq, - substraitExprName, - timeAdd.children, - timeAdd - ) case ss: StringSplit => BackendsApiManager.getSparkPlanExecApiInstance.genStringSplitTransformer( substraitExprName, diff --git a/gluten-substrait/src/main/scala/org/apache/gluten/expression/ExpressionMappings.scala b/gluten-substrait/src/main/scala/org/apache/gluten/expression/ExpressionMappings.scala index b0b7c80793..b13aced2a6 100644 --- a/gluten-substrait/src/main/scala/org/apache/gluten/expression/ExpressionMappings.scala +++ b/gluten-substrait/src/main/scala/org/apache/gluten/expression/ExpressionMappings.scala @@ -179,7 +179,6 @@ object ExpressionMappings { Sig[Second](EXTRACT), Sig[FromUnixTime](FROM_UNIXTIME), Sig[DateAdd](DATE_ADD), - Sig[TimeAdd](TIMESTAMP_ADD), Sig[DateSub](DATE_SUB), Sig[DateDiff](DATE_DIFF), Sig[ToUnixTimestamp](TO_UNIX_TIMESTAMP), --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
