zhztheplayer commented on code in PR #11326:
URL:
https://github.com/apache/incubator-gluten/pull/11326#discussion_r2661104609
##########
cpp/velox/memory/VeloxColumnarBatch.h:
##########
@@ -29,6 +29,13 @@ class VeloxColumnarBatch final : public ColumnarBatch {
VeloxColumnarBatch(facebook::velox::RowVectorPtr rowVector)
: ColumnarBatch(rowVector->childrenSize(), rowVector->size()),
rowVector_(rowVector) {}
+#ifdef GLUTEN_ENABLE_GPU
+ // The batch may be CudfVector, it's childrenSize is not correct, many tests
failed if correcting the value
+ //
https://github.com/facebookincubator/velox/pull/15629#discussion_r2581655771
+ VeloxColumnarBatch(facebook::velox::RowVectorPtr rowVector, int32_t
numColumns)
+ : ColumnarBatch(numColumns, rowVector->size()), rowVector_(rowVector) {}
+#endif
Review Comment:
Compared to adding a new ctor, what if we just change the old ctor to call
`rowVector->rowType()->size()`?
By the way. Why `childrenSize()` is inaccurate for cuDF row vector?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
