jackylee-ch commented on issue #11376: URL: https://github.com/apache/incubator-gluten/issues/11376#issuecomment-3717881050
There is a benchmark result for [castFromVarcharAddTrimNode](https://github.com/apache/incubator-gluten/pull/7476#issuecomment-2409877070) show a 1.x speedup when trimming is disabled. Since Velox already handles common cases trimming for strings, we propose defaulting this setting to `false` to maintain optimal performance. Users can manually enable it if they need to handle the specific edge cases. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
