jackylee-ch commented on code in PR #7752:
URL: https://github.com/apache/incubator-gluten/pull/7752#discussion_r1827159970
##########
backends-velox/src/main/scala/org/apache/gluten/execution/HashAggregateExecTransformer.scala:
##########
@@ -356,7 +356,7 @@ abstract class HashAggregateExecTransformer(
// The process of handling the inconsistency in column types and
order between
// Spark and Velox is exactly the opposite of applyExtractStruct.
aggregateExpression.mode match {
- case PartialMerge | Final =>
+ case PartialMerge | Final | Complete =>
Review Comment:
I used #6198 to support COMPLETE Mode for velox before. If ok, I can do
double check for your pr to see if there is some prolem with it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
