rui-mo commented on code in PR #11358:
URL:
https://github.com/apache/incubator-gluten/pull/11358#discussion_r2684926268
##########
backends-velox/src/main/scala/org/apache/gluten/execution/HashAggregateExecTransformer.scala:
##########
@@ -284,7 +284,7 @@ abstract class HashAggregateExecTransformer(
val aggFunc = aggregateExpression.aggregateFunction
val functionInputAttributes = aggFunc.inputAggBufferAttributes
aggFunc match {
- case _ if aggregateExpression.mode == Partial =>
+ case _ if aggregateExpression.mode == Partial ||
aggregateExpression.mode == Complete =>
Review Comment:
I understand that mixing Complete mode with other modes isn’t supported, but
is there a way to add a unit test for pure Complete mode to ensure this works?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
