infvg commented on code in PR #11392:
URL:
https://github.com/apache/incubator-gluten/pull/11392#discussion_r2685820501
##########
backends-velox/src/main/scala/org/apache/gluten/config/VeloxConfig.scala:
##########
@@ -447,6 +451,21 @@ object VeloxConfig extends ConfigRegistry {
.longConf
.createWithDefault(4194304L)
+ val COLUMNAR_VELOX_HASH_PROBE_BLOOM_FILTER_PUSHDOWN_MAX_SIZE =
+
buildConf("spark.gluten.sql.columnar.backend.velox.hash_probe_bloom_filter_pushdown_max_size")
Review Comment:
Ah I see, I changed it. I set it to `hashProbe.bloomFilterPushdown.maxSize`
since it feels more natural since we are setting the max size. Please let me
know what you think
##########
backends-velox/src/main/scala/org/apache/gluten/config/VeloxConfig.scala:
##########
@@ -85,6 +85,10 @@ class VeloxConfig(conf: SQLConf) extends GlutenConfig(conf) {
def orcUseColumnNames: Boolean = getConf(ORC_USE_COLUMN_NAMES)
def parquetUseColumnNames: Boolean = getConf(PARQUET_USE_COLUMN_NAMES)
+
+ def veloxHashProbeBloomFilterPushdownMaxSize: Long =
getConf(COLUMNAR_VELOX_HASH_PROBE_BLOOM_FILTER_PUSHDOWN_MAX_SIZE)
Review Comment:
Changed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
