PHILO-HE commented on code in PR #11351:
URL:
https://github.com/apache/incubator-gluten/pull/11351#discussion_r2702996366
##########
.github/workflows/velox_backend_x86.yml:
##########
@@ -46,6 +46,7 @@ env:
MVN_CMD: 'build/mvn -ntp'
WGET_CMD: 'wget -nv'
CCACHE_DIR: "${{ github.workspace }}/.ccache"
+ SETUP: 'source .github/workflows/util/setup-helper.sh'
Review Comment:
Remove this line if not required.
##########
docs/get-started/build-guide.md:
##########
@@ -8,27 +8,27 @@ parent: Getting-Started
### Native build parameters for buildbundle-veloxbe.sh or builddeps-veloxbe.sh
Please set them via `--`, e.g. `--build_type=Release`.
-| Parameters | Description
| Default |
-|------------------------|----------------------------------------------------------------------------------------------------|---------|
-| build_type | Build type for Velox & gluten cpp,
CMAKE_BUILD_TYPE. | Release |
-| build_tests | Build gluten cpp tests.
| OFF |
-| build_examples | Build udf example.
| OFF |
-| build_benchmarks | Build gluten cpp benchmarks.
| OFF |
-| enable_jemalloc_stats | Print jemalloc stats for debugging.
| OFF |
-| enable_qat | Enable QAT for shuffle data de/compression.
| OFF |
-| enable_s3 | Build with S3 support.
| OFF |
-| enable_gcs | Build with GCS support.
| OFF |
-| enable_hdfs | Build with HDFS support.
| OFF |
-| enable_abfs | Build with ABFS support.
| OFF |
-| enable_vcpkg | Enable vcpkg for static build.
| OFF |
-| run_setup_script | Run setup script to install Velox dependencies.
| ON |
-| velox_repo | Specify your own Velox repo to build.
| "" |
-| velox_branch | Specify your own Velox branch to build.
| "" |
-| velox_home | Specify your own Velox source path to build.
| "" |
-| build_velox_tests | Build Velox tests.
| OFF |
-| build_velox_benchmarks | Build Velox benchmarks (velox_tests and connectors
will be disabled if ON) | OFF |
-| build_arrow | Build arrow java/cpp and install the libs in local.
Can turn it OFF after first build. | ON |
-| spark_version | Build for specified version of Spark(3.2, 3.3, 3.4,
3.5, ALL). `ALL` means build for all versions. | ALL |
+| Parameters | Description
| Default |
+|------------------------|-----------------------------------------------------------------------------------------------|---------|
+| build_type | Build type for Velox & gluten cpp,
CMAKE_BUILD_TYPE. | Release |
+| build_tests | Build gluten cpp tests.
| OFF |
+| build_examples | Build udf example.
| OFF |
+| build_benchmarks | Build gluten cpp benchmarks.
| OFF |
+| enable_jemalloc_stats | Print jemalloc stats for debugging.
| OFF |
+| enable_qat | Enable QAT for shuffle data de/compression.
| OFF |
+| enable_s3 | Build with S3 support.
| OFF |
+| enable_gcs | Build with GCS support.
| OFF |
+| enable_hdfs | Build with HDFS support.
| OFF |
+| enable_abfs | Build with ABFS support.
| OFF |
+| enable_vcpkg | Enable vcpkg for static build.
| OFF |
+| run_setup_script | Run setup script to install Velox dependencies.
| ON |
+| velox_repo | Specify your own Velox repo to build.
| "" |
+| velox_branch | Specify your own Velox branch to build.
| "" |
+| velox_home | Specify your own Velox source path to build.
| "" |
+| build_velox_tests | Build Velox tests.
| OFF |
+| build_velox_benchmarks | Build Velox benchmarks (velox_tests and connectors
will be disabled if ON) | OFF |
+| build_arrow | Build arrow java/cpp and install the libs in local.
Can turn it OFF after first build. | ON |
+| spark_version | Build for specified version of Spark(3.3, 3.4, 3.5,
ALL). `ALL` means build for all versions. | ALL |
Review Comment:
Could you update this line to include 4.0, 4.1?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
