PHILO-HE commented on code in PR #11457:
URL:
https://github.com/apache/incubator-gluten/pull/11457#discussion_r2715080863
##########
dev/build-helper-functions.sh:
##########
@@ -74,7 +74,52 @@ function get_cxx_flags {
;;
"aarch64")
- echo -n "-mcpu=neoverse-n1 -std=c++20 $ADDITIONAL_FLAGS"
+ # Follow Velox's ARM CPU detection logic to ensure consistent compiler
flags
+ # between Gluten and Velox, preventing xsimd initialization issues.
+ # See:
ep/build-velox/build/velox_ep/scripts/setup-helper-functions.sh:142-180
Review Comment:
Nit: The line numbers can be invalid very likely during Velox's iteration.
Suggest the following comment.
`Reference: function get_cxx_flags in Velox's setup-helper-functions.sh.`
##########
dev/build-helper-functions.sh:
##########
@@ -74,7 +74,52 @@ function get_cxx_flags {
;;
"aarch64")
- echo -n "-mcpu=neoverse-n1 -std=c++20 $ADDITIONAL_FLAGS"
+ # Follow Velox's ARM CPU detection logic to ensure consistent compiler
flags
+ # between Gluten and Velox, preventing xsimd initialization issues.
Review Comment:
Suggest adding the issue to make it clear to developers.
`preventing xsimd initialization issues, see GLUTEN-11390.`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
