taiyang-li commented on PR #11454: URL: https://github.com/apache/incubator-gluten/pull/11454#issuecomment-3783988652
> Have you tested whether snappy can be used with this patch? I wonder if some changes are needed in the cpp code. For example we need to support building the snappy codec here > > https://github.com/apache/incubator-gluten/blob/main/cpp/core/utils/Compression.cc#L28-L61 > > Please also enable `arrow::Compression::SNAPPY` in the cpp unit test if possible > > https://github.com/apache/incubator-gluten/blob/main/cpp/velox/tests/VeloxShuffleWriterTest.cc#L101-L102 @marin-ma thanks for your remainding. I'll continue the work. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
