baibaichen commented on code in PR #11481:
URL:
https://github.com/apache/incubator-gluten/pull/11481#discussion_r2726833599
##########
backends-velox/src/test/scala/org/apache/gluten/execution/python/ArrowEvalPythonExecSuite.scala:
##########
@@ -65,8 +64,7 @@ class ArrowEvalPythonExecSuite extends
WholeStageTransformerSuite {
checkAnswer(df2, expected)
}
- // TODO: fix on spark-4.1
- testWithMaxSparkVersion("arrow_udf test: with unrelated projection", "4.0") {
+ testWithMaxSparkVersion("arrow_udf test: with unrelated projection", "4.1") {
Review Comment:
use `test` directly
##########
backends-velox/src/test/scala/org/apache/gluten/execution/python/ArrowEvalPythonExecSuite.scala:
##########
@@ -87,8 +85,7 @@ class ArrowEvalPythonExecSuite extends
WholeStageTransformerSuite {
checkAnswer(df, expected)
}
- // TODO: fix on spark-4.1
- testWithMaxSparkVersion("arrow_udf test: with preprojection", "4.0") {
+ testWithMaxSparkVersion("arrow_udf test: with preprojection", "4.1") {
Review Comment:
ditto
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]