PHILO-HE commented on code in PR #11287:
URL:
https://github.com/apache/incubator-gluten/pull/11287#discussion_r2730014509
##########
dev/builddeps-veloxbe.sh:
##########
@@ -237,7 +242,13 @@ function build_gluten_cpp {
rm -rf build
mkdir build
cd build
-
+ if [ $USE_CLANG = "ON" ]; then
+ export CC="clang"
+ export CXX="clang++"
+ # Compiling with clang requires gcc11
+ export CXXFLAGS="-stdlib=libstdc++
-I/opt/rh/gcc-toolset-11/root/usr/include/c++/11
-I/opt/rh/gcc-toolset-11/root/usr/include/c++/11/x86_64-redhat-linux"
+ export LDFLAGS="-L/opt/rh/gcc-toolset-11/root/usr/lib64
-Wl,-rpath,/opt/rh/gcc-toolset-11/root/usr/lib64 -stdlib=libstdc++"
Review Comment:
These two lines of setting are specific to the OS used in this CI job. Move
to the CI job section.
##########
.github/workflows/iwyu.yml:
##########
@@ -0,0 +1,120 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+name: Include What You Use Check
+
+on:
+ pull_request:
+ paths:
+ - '.github/workflows/iwyu.yml'
+ - 'cpp/**/*.cc'
+ - 'cpp/**/*.h'
+
+env:
+ ACTIONS_ALLOW_USE_UNSECURE_NODE_VERSION: true
+ CCACHE_DIR: "${{ github.workspace }}/.ccache"
+
+concurrency:
+ group: ${{ github.repository }}-${{ github.head_ref || github.sha }}-${{
github.workflow }}
+ cancel-in-progress: true
+
+jobs:
+ build-native-lib-centos-8:
+ runs-on: ubuntu-22.04
+ steps:
+ - uses: actions/checkout@v4
+ - name: Get Ccache
+ uses: actions/cache/restore@v4
+ with:
+ path: '${{ env.CCACHE_DIR }}'
+ key: ccache-centos8-release-default-${{github.sha}}
+ restore-keys: |
+ ccache-centos8-release-default
+ - name: Build Gluten native libraries
+ run: |
+ docker pull apache/gluten:vcpkg-centos-8
+ docker run -v $GITHUB_WORKSPACE:/work -w /work
apache/gluten:vcpkg-centos-8 bash -c "
Review Comment:
Set `container` field with this image, a standard way for GHA.
##########
.github/workflows/iwyu.yml:
##########
@@ -0,0 +1,120 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+name: Include What You Use Check
+
+on:
+ pull_request:
+ paths:
+ - '.github/workflows/iwyu.yml'
+ - 'cpp/**/*.cc'
+ - 'cpp/**/*.h'
+
+env:
+ ACTIONS_ALLOW_USE_UNSECURE_NODE_VERSION: true
+ CCACHE_DIR: "${{ github.workspace }}/.ccache"
+
+concurrency:
+ group: ${{ github.repository }}-${{ github.head_ref || github.sha }}-${{
github.workflow }}
+ cancel-in-progress: true
+
+jobs:
+ build-native-lib-centos-8:
+ runs-on: ubuntu-22.04
+ steps:
+ - uses: actions/checkout@v4
+ - name: Get Ccache
+ uses: actions/cache/restore@v4
+ with:
+ path: '${{ env.CCACHE_DIR }}'
+ key: ccache-centos8-release-default-${{github.sha}}
+ restore-keys: |
+ ccache-centos8-release-default
+ - name: Build Gluten native libraries
+ run: |
+ docker pull apache/gluten:vcpkg-centos-8
+ docker run -v $GITHUB_WORKSPACE:/work -w /work
apache/gluten:vcpkg-centos-8 bash -c "
+ set -e
+ yum install tzdata -y
+ source /opt/rh/gcc-toolset-11/enable
+ cd /work
+ export CCACHE_DIR=/work/.ccache
+ mkdir -p /work/.ccache
+ wget -q
https://github.com/llvm/llvm-project/releases/download/llvmorg-18.1.8/clang+llvm-18.1.8-x86_64-linux-gnu-ubuntu-18.04.tar.xz
+ tar -xf clang+llvm-18.1.8-x86_64-linux-gnu-ubuntu-18.04.tar.xz
+ rm -rf clang+llvm-18.1.8-x86_64-linux-gnu-ubuntu-18.04.tar.xz
+ cd /work/clang+llvm-18.1.8-x86_64-linux-gnu-ubuntu-18.04/bin/ &&
ls -1 | grep -v \"^clang\" | xargs rm -rf
+ ln -s /lib64/libtinfo.so.6.1 /lib64/libtinfo.so.5
+ ln -s
/work/clang+llvm-18.1.8-x86_64-linux-gnu-ubuntu-18.04/bin/clang /usr/bin/clang
+ ln -s
/work/clang+llvm-18.1.8-x86_64-linux-gnu-ubuntu-18.04/bin/clang++
/usr/bin/clang++
+ ln -sf
/opt/rh/gcc-toolset-11/root/usr/lib/gcc/x86_64-redhat-linux/11/libstdc++.a
/usr/lib64/libstdc++.a
+ cd /work
+ bash dev/ci-velox-buildstatic-centos-8-clang.sh
+ mkdir -p /work/.m2/repository/org/apache/arrow/
+ cp -r /root/.m2/repository/org/apache/arrow/*
/work/.m2/repository/org/apache/arrow/
+ "
+ - name: "Save ccache"
+ uses: actions/cache/save@v4
+ id: ccache
+ with:
+ path: '${{ env.CCACHE_DIR }}'
+ key: ccache-centos8-release-default-${{github.sha}}
+ - uses: actions/upload-artifact@v4
+ with:
+ name: velox-native-lib-centos-8-${{github.sha}}
+ path: ./cpp/build/
+ if-no-files-found: error
+ - uses: actions/upload-artifact@v4
+ with:
+ name: arrow-jars-centos-8-${{github.sha}}
+ path: .m2/repository/org/apache/arrow/
+ if-no-files-found: error
+
+ iwyu-check:
+ needs: build-native-lib-centos-8
+ runs-on: ubuntu-22.04
+ container: apache/gluten:centos-8-jdk8
+ steps:
+ - uses: actions/checkout@v4
+ with:
+ fetch-depth: 0
+ - uses: actions/download-artifact@v4
+ with:
+ name: velox-native-lib-centos-8-${{github.sha}}
+ path: ./cpp/build/
+ - name: build include-what-you-use
+ run: |
+ yum install -y llvm llvm-devel clang clang-devel llvm-toolset
+ cd $GITHUB_WORKSPACE/
+ git clone
https://github.com/include-what-you-use/include-what-you-use.git
+ cd include-what-you-use
+ git checkout clang_12
+ mkdir build && cd build
+ cmake -G "Unix Makefiles" -DCMAKE_PREFIX_PATH=/usr/include/llvm ../
+ make -j$(nproc)
+ ls ./bin
+ ln -s
$GITHUB_WORKSPACE/include-what-you-use/build/bin/include-what-you-use
/usr/bin/include-what-you-use
+ - name: Check Include What You Use
+ run: |
+ pip3 install regex
+ cd $GITHUB_WORKSPACE/
+ sed -i "s|/work|$(pwd)|g" cpp/build/compile_commands.json
+ ls /usr/bin/include-what-you-use
+ export
CPLUS_INCLUDE_PATH=/opt/rh/gcc-toolset-11/root/usr/lib/gcc/x86_64-redhat-linux/11/include
+ export CXXFLAGS="--gcc-toolchain=/opt/rh/gcc-toolset-11/root/usr"
+ wget
https://github.com/include-what-you-use/include-what-you-use/archive/refs/tags/0.25.tar.gz
+ tar -xzvf 0.25.tar.gz
+ cp include-what-you-use-0.25/iwyu_tool.py dev/iwyu_tool.py
Review Comment:
Suggest moving the build and the download for IWYU into `setup-helper.sh`.
##########
dev/builddeps-veloxbe.sh:
##########
@@ -237,7 +242,13 @@ function build_gluten_cpp {
rm -rf build
mkdir build
cd build
-
+ if [ $USE_CLANG = "ON" ]; then
Review Comment:
To separate the builds, we can run `./dev/builddeps-veloxbe.sh build_velox
xxx` with gcc to utilize vcpkg cache in docker. Then, run
`./dev/builddeps-veloxbe.sh build_gluten_cpp` with clang to build Gluten c++
code.
##########
.github/workflows/iwyu.yml:
##########
@@ -0,0 +1,120 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+name: Include What You Use Check
+
+on:
+ pull_request:
+ paths:
+ - '.github/workflows/iwyu.yml'
+ - 'cpp/**/*.cc'
+ - 'cpp/**/*.h'
+
+env:
+ ACTIONS_ALLOW_USE_UNSECURE_NODE_VERSION: true
+ CCACHE_DIR: "${{ github.workspace }}/.ccache"
+
+concurrency:
+ group: ${{ github.repository }}-${{ github.head_ref || github.sha }}-${{
github.workflow }}
+ cancel-in-progress: true
+
+jobs:
+ build-native-lib-centos-8:
+ runs-on: ubuntu-22.04
+ steps:
+ - uses: actions/checkout@v4
+ - name: Get Ccache
+ uses: actions/cache/restore@v4
+ with:
+ path: '${{ env.CCACHE_DIR }}'
+ key: ccache-centos8-release-default-${{github.sha}}
+ restore-keys: |
+ ccache-centos8-release-default
+ - name: Build Gluten native libraries
+ run: |
+ docker pull apache/gluten:vcpkg-centos-8
+ docker run -v $GITHUB_WORKSPACE:/work -w /work
apache/gluten:vcpkg-centos-8 bash -c "
+ set -e
+ yum install tzdata -y
+ source /opt/rh/gcc-toolset-11/enable
+ cd /work
+ export CCACHE_DIR=/work/.ccache
+ mkdir -p /work/.ccache
+ wget -q
https://github.com/llvm/llvm-project/releases/download/llvmorg-18.1.8/clang+llvm-18.1.8-x86_64-linux-gnu-ubuntu-18.04.tar.xz
+ tar -xf clang+llvm-18.1.8-x86_64-linux-gnu-ubuntu-18.04.tar.xz
+ rm -rf clang+llvm-18.1.8-x86_64-linux-gnu-ubuntu-18.04.tar.xz
+ cd /work/clang+llvm-18.1.8-x86_64-linux-gnu-ubuntu-18.04/bin/ &&
ls -1 | grep -v \"^clang\" | xargs rm -rf
+ ln -s /lib64/libtinfo.so.6.1 /lib64/libtinfo.so.5
+ ln -s
/work/clang+llvm-18.1.8-x86_64-linux-gnu-ubuntu-18.04/bin/clang /usr/bin/clang
+ ln -s
/work/clang+llvm-18.1.8-x86_64-linux-gnu-ubuntu-18.04/bin/clang++
/usr/bin/clang++
+ ln -sf
/opt/rh/gcc-toolset-11/root/usr/lib/gcc/x86_64-redhat-linux/11/libstdc++.a
/usr/lib64/libstdc++.a
+ cd /work
+ bash dev/ci-velox-buildstatic-centos-8-clang.sh
+ mkdir -p /work/.m2/repository/org/apache/arrow/
+ cp -r /root/.m2/repository/org/apache/arrow/*
/work/.m2/repository/org/apache/arrow/
+ "
+ - name: "Save ccache"
+ uses: actions/cache/save@v4
+ id: ccache
+ with:
+ path: '${{ env.CCACHE_DIR }}'
+ key: ccache-centos8-release-default-${{github.sha}}
+ - uses: actions/upload-artifact@v4
+ with:
+ name: velox-native-lib-centos-8-${{github.sha}}
+ path: ./cpp/build/
+ if-no-files-found: error
+ - uses: actions/upload-artifact@v4
+ with:
+ name: arrow-jars-centos-8-${{github.sha}}
+ path: .m2/repository/org/apache/arrow/
Review Comment:
Remove. The arrow JAR is useless.
##########
.github/workflows/iwyu.yml:
##########
@@ -0,0 +1,120 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+name: Include What You Use Check
+
+on:
+ pull_request:
+ paths:
+ - '.github/workflows/iwyu.yml'
+ - 'cpp/**/*.cc'
+ - 'cpp/**/*.h'
+
+env:
+ ACTIONS_ALLOW_USE_UNSECURE_NODE_VERSION: true
+ CCACHE_DIR: "${{ github.workspace }}/.ccache"
+
+concurrency:
+ group: ${{ github.repository }}-${{ github.head_ref || github.sha }}-${{
github.workflow }}
+ cancel-in-progress: true
+
+jobs:
+ build-native-lib-centos-8:
+ runs-on: ubuntu-22.04
+ steps:
+ - uses: actions/checkout@v4
+ - name: Get Ccache
+ uses: actions/cache/restore@v4
+ with:
+ path: '${{ env.CCACHE_DIR }}'
+ key: ccache-centos8-release-default-${{github.sha}}
+ restore-keys: |
+ ccache-centos8-release-default
+ - name: Build Gluten native libraries
+ run: |
+ docker pull apache/gluten:vcpkg-centos-8
+ docker run -v $GITHUB_WORKSPACE:/work -w /work
apache/gluten:vcpkg-centos-8 bash -c "
+ set -e
+ yum install tzdata -y
+ source /opt/rh/gcc-toolset-11/enable
+ cd /work
+ export CCACHE_DIR=/work/.ccache
+ mkdir -p /work/.ccache
+ wget -q
https://github.com/llvm/llvm-project/releases/download/llvmorg-18.1.8/clang+llvm-18.1.8-x86_64-linux-gnu-ubuntu-18.04.tar.xz
+ tar -xf clang+llvm-18.1.8-x86_64-linux-gnu-ubuntu-18.04.tar.xz
+ rm -rf clang+llvm-18.1.8-x86_64-linux-gnu-ubuntu-18.04.tar.xz
+ cd /work/clang+llvm-18.1.8-x86_64-linux-gnu-ubuntu-18.04/bin/ &&
ls -1 | grep -v \"^clang\" | xargs rm -rf
+ ln -s /lib64/libtinfo.so.6.1 /lib64/libtinfo.so.5
+ ln -s
/work/clang+llvm-18.1.8-x86_64-linux-gnu-ubuntu-18.04/bin/clang /usr/bin/clang
+ ln -s
/work/clang+llvm-18.1.8-x86_64-linux-gnu-ubuntu-18.04/bin/clang++
/usr/bin/clang++
+ ln -sf
/opt/rh/gcc-toolset-11/root/usr/lib/gcc/x86_64-redhat-linux/11/libstdc++.a
/usr/lib64/libstdc++.a
+ cd /work
+ bash dev/ci-velox-buildstatic-centos-8-clang.sh
+ mkdir -p /work/.m2/repository/org/apache/arrow/
+ cp -r /root/.m2/repository/org/apache/arrow/*
/work/.m2/repository/org/apache/arrow/
+ "
+ - name: "Save ccache"
+ uses: actions/cache/save@v4
+ id: ccache
+ with:
+ path: '${{ env.CCACHE_DIR }}'
+ key: ccache-centos8-release-default-${{github.sha}}
+ - uses: actions/upload-artifact@v4
+ with:
+ name: velox-native-lib-centos-8-${{github.sha}}
+ path: ./cpp/build/
Review Comment:
If not necessary to use two jobs, we can unify them into one and remove the
uploading.
##########
dev/builddeps-veloxbe.sh:
##########
@@ -237,7 +242,13 @@ function build_gluten_cpp {
rm -rf build
mkdir build
cd build
-
+ if [ $USE_CLANG = "ON" ]; then
Review Comment:
Seems no need to add a new build option. Just let the compilation depend on
the setting for CC and CXX in the env.
##########
.github/workflows/iwyu.yml:
##########
@@ -0,0 +1,120 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+name: Include What You Use Check
+
+on:
+ pull_request:
+ paths:
+ - '.github/workflows/iwyu.yml'
+ - 'cpp/**/*.cc'
+ - 'cpp/**/*.h'
+
+env:
+ ACTIONS_ALLOW_USE_UNSECURE_NODE_VERSION: true
+ CCACHE_DIR: "${{ github.workspace }}/.ccache"
+
+concurrency:
+ group: ${{ github.repository }}-${{ github.head_ref || github.sha }}-${{
github.workflow }}
+ cancel-in-progress: true
+
+jobs:
+ build-native-lib-centos-8:
+ runs-on: ubuntu-22.04
+ steps:
+ - uses: actions/checkout@v4
+ - name: Get Ccache
+ uses: actions/cache/restore@v4
+ with:
+ path: '${{ env.CCACHE_DIR }}'
+ key: ccache-centos8-release-default-${{github.sha}}
+ restore-keys: |
+ ccache-centos8-release-default
+ - name: Build Gluten native libraries
+ run: |
+ docker pull apache/gluten:vcpkg-centos-8
+ docker run -v $GITHUB_WORKSPACE:/work -w /work
apache/gluten:vcpkg-centos-8 bash -c "
+ set -e
+ yum install tzdata -y
+ source /opt/rh/gcc-toolset-11/enable
+ cd /work
+ export CCACHE_DIR=/work/.ccache
+ mkdir -p /work/.ccache
+ wget -q
https://github.com/llvm/llvm-project/releases/download/llvmorg-18.1.8/clang+llvm-18.1.8-x86_64-linux-gnu-ubuntu-18.04.tar.xz
+ tar -xf clang+llvm-18.1.8-x86_64-linux-gnu-ubuntu-18.04.tar.xz
+ rm -rf clang+llvm-18.1.8-x86_64-linux-gnu-ubuntu-18.04.tar.xz
+ cd /work/clang+llvm-18.1.8-x86_64-linux-gnu-ubuntu-18.04/bin/ &&
ls -1 | grep -v \"^clang\" | xargs rm -rf
+ ln -s /lib64/libtinfo.so.6.1 /lib64/libtinfo.so.5
+ ln -s
/work/clang+llvm-18.1.8-x86_64-linux-gnu-ubuntu-18.04/bin/clang /usr/bin/clang
+ ln -s
/work/clang+llvm-18.1.8-x86_64-linux-gnu-ubuntu-18.04/bin/clang++
/usr/bin/clang++
+ ln -sf
/opt/rh/gcc-toolset-11/root/usr/lib/gcc/x86_64-redhat-linux/11/libstdc++.a
/usr/lib64/libstdc++.a
+ cd /work
+ bash dev/ci-velox-buildstatic-centos-8-clang.sh
+ mkdir -p /work/.m2/repository/org/apache/arrow/
+ cp -r /root/.m2/repository/org/apache/arrow/*
/work/.m2/repository/org/apache/arrow/
Review Comment:
Remove.
##########
dev/ci-velox-buildstatic-centos-8-clang.sh:
##########
@@ -0,0 +1,28 @@
+#!/bin/bash
+
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+set -e
+
+source /opt/rh/gcc-toolset-11/enable
+if [ "$(uname -m)" = "aarch64" ]; then
+ export CPU_TARGET="aarch64";
+ export VCPKG_FORCE_SYSTEM_BINARIES=1;
+fi
+
+export NUM_THREADS=$(nproc)
+./dev/builddeps-veloxbe.sh --enable_vcpkg=ON --build_arrow=OFF
--build_tests=OFF --build_benchmarks=OFF --use_clang=ON\
+ --build_examples=OFF --enable_s3=ON --enable_gcs=ON
--enable_hdfs=ON --enable_abfs=ON
Review Comment:
Suggest removing this file if this script is only used once and separate
builds will be introduced.
##########
.github/workflows/iwyu.yml:
##########
@@ -0,0 +1,120 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+name: Include What You Use Check
+
+on:
+ pull_request:
+ paths:
+ - '.github/workflows/iwyu.yml'
+ - 'cpp/**/*.cc'
+ - 'cpp/**/*.h'
+
+env:
+ ACTIONS_ALLOW_USE_UNSECURE_NODE_VERSION: true
+ CCACHE_DIR: "${{ github.workspace }}/.ccache"
+
+concurrency:
+ group: ${{ github.repository }}-${{ github.head_ref || github.sha }}-${{
github.workflow }}
+ cancel-in-progress: true
+
+jobs:
+ build-native-lib-centos-8:
+ runs-on: ubuntu-22.04
+ steps:
+ - uses: actions/checkout@v4
+ - name: Get Ccache
+ uses: actions/cache/restore@v4
+ with:
+ path: '${{ env.CCACHE_DIR }}'
+ key: ccache-centos8-release-default-${{github.sha}}
+ restore-keys: |
+ ccache-centos8-release-default
+ - name: Build Gluten native libraries
+ run: |
+ docker pull apache/gluten:vcpkg-centos-8
+ docker run -v $GITHUB_WORKSPACE:/work -w /work
apache/gluten:vcpkg-centos-8 bash -c "
+ set -e
+ yum install tzdata -y
+ source /opt/rh/gcc-toolset-11/enable
+ cd /work
+ export CCACHE_DIR=/work/.ccache
+ mkdir -p /work/.ccache
+ wget -q
https://github.com/llvm/llvm-project/releases/download/llvmorg-18.1.8/clang+llvm-18.1.8-x86_64-linux-gnu-ubuntu-18.04.tar.xz
+ tar -xf clang+llvm-18.1.8-x86_64-linux-gnu-ubuntu-18.04.tar.xz
+ rm -rf clang+llvm-18.1.8-x86_64-linux-gnu-ubuntu-18.04.tar.xz
+ cd /work/clang+llvm-18.1.8-x86_64-linux-gnu-ubuntu-18.04/bin/ &&
ls -1 | grep -v \"^clang\" | xargs rm -rf
+ ln -s /lib64/libtinfo.so.6.1 /lib64/libtinfo.so.5
+ ln -s
/work/clang+llvm-18.1.8-x86_64-linux-gnu-ubuntu-18.04/bin/clang /usr/bin/clang
+ ln -s
/work/clang+llvm-18.1.8-x86_64-linux-gnu-ubuntu-18.04/bin/clang++
/usr/bin/clang++
+ ln -sf
/opt/rh/gcc-toolset-11/root/usr/lib/gcc/x86_64-redhat-linux/11/libstdc++.a
/usr/lib64/libstdc++.a
+ cd /work
+ bash dev/ci-velox-buildstatic-centos-8-clang.sh
+ mkdir -p /work/.m2/repository/org/apache/arrow/
+ cp -r /root/.m2/repository/org/apache/arrow/*
/work/.m2/repository/org/apache/arrow/
+ "
+ - name: "Save ccache"
+ uses: actions/cache/save@v4
+ id: ccache
+ with:
+ path: '${{ env.CCACHE_DIR }}'
+ key: ccache-centos8-release-default-${{github.sha}}
+ - uses: actions/upload-artifact@v4
+ with:
+ name: velox-native-lib-centos-8-${{github.sha}}
+ path: ./cpp/build/
+ if-no-files-found: error
+ - uses: actions/upload-artifact@v4
+ with:
+ name: arrow-jars-centos-8-${{github.sha}}
+ path: .m2/repository/org/apache/arrow/
+ if-no-files-found: error
+
+ iwyu-check:
+ needs: build-native-lib-centos-8
+ runs-on: ubuntu-22.04
+ container: apache/gluten:centos-8-jdk8
+ steps:
+ - uses: actions/checkout@v4
+ with:
+ fetch-depth: 0
+ - uses: actions/download-artifact@v4
+ with:
+ name: velox-native-lib-centos-8-${{github.sha}}
+ path: ./cpp/build/
+ - name: build include-what-you-use
+ run: |
+ yum install -y llvm llvm-devel clang clang-devel llvm-toolset
+ cd $GITHUB_WORKSPACE/
+ git clone
https://github.com/include-what-you-use/include-what-you-use.git
Review Comment:
Suggest using a release version for stability consideration.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
