Copilot commented on code in PR #11545:
URL:
https://github.com/apache/incubator-gluten/pull/11545#discussion_r2754090171
##########
pom.xml:
##########
@@ -483,6 +483,57 @@
</dependencies>
</dependencyManagement>
+ <!-- Use Google Cloud Storage mirror for faster Maven Central downloads -->
+ <repositories>
+ <repository>
+ <releases>
+ <enabled>true</enabled>
+ </releases>
+ <snapshots>
+ <enabled>false</enabled>
+ </snapshots>
+ <id>gcs-maven-central-mirror</id>
+ <name>GCS Maven Central mirror</name>
+ <url>https://maven-central.storage-download.googleapis.com/maven2/</url>
+ </repository>
+ <repository>
+ <releases>
+ <enabled>true</enabled>
+ </releases>
+ <snapshots>
+ <enabled>false</enabled>
+ </snapshots>
+ <id>central</id>
+ <name>Maven Repository Switchboard</name>
Review Comment:
`<name>Maven Repository Switchboard</name>` is outdated/misleading
terminology for Maven Central (the switchboard service was retired years ago).
Consider renaming it to "Maven Central" (or omit `<name>` entirely) to avoid
confusion when debugging repository resolution.
```suggestion
<name>Maven Central</name>
```
##########
pom.xml:
##########
@@ -483,6 +483,57 @@
</dependencies>
</dependencyManagement>
+ <!-- Use Google Cloud Storage mirror for faster Maven Central downloads -->
+ <repositories>
+ <repository>
+ <releases>
Review Comment:
PR description says this is not user-facing, but adding repositories at the
parent POM level affects dependency/plugin resolution for any consumers that
use this parent POM (not just local builds). Either update the PR description
to reflect this impact or scope the change to the build wrapper/CI
settings/profile so it remains build-only.
##########
pom.xml:
##########
@@ -483,6 +483,57 @@
</dependencies>
</dependencyManagement>
+ <!-- Use Google Cloud Storage mirror for faster Maven Central downloads -->
+ <repositories>
+ <repository>
+ <releases>
+ <enabled>true</enabled>
+ </releases>
+ <snapshots>
+ <enabled>false</enabled>
+ </snapshots>
+ <id>gcs-maven-central-mirror</id>
+ <name>GCS Maven Central mirror</name>
+ <url>https://maven-central.storage-download.googleapis.com/maven2/</url>
+ </repository>
+ <repository>
+ <releases>
+ <enabled>true</enabled>
+ </releases>
+ <snapshots>
+ <enabled>false</enabled>
+ </snapshots>
+ <id>central</id>
+ <name>Maven Repository Switchboard</name>
+ <url>https://repo.maven.apache.org/maven2</url>
+ </repository>
+ </repositories>
Review Comment:
Adding `<repositories>` / `<pluginRepositories>` to the published parent POM
changes the effective POM for all modules and any external projects inheriting
from it, forcing an extra remote (googleapis.com) into their resolution path.
For build-speed improvements, prefer configuring a Maven mirror in
`settings.xml` (e.g., wired via `build/mvn` or CI with `-s`) or make this
repository opt-in via a Maven profile/property so downstream users can avoid it
in restricted networks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
