PHILO-HE commented on code in PR #11528:
URL:
https://github.com/apache/incubator-gluten/pull/11528#discussion_r2754209178
##########
.github/workflows/velox_nightly.yml:
##########
@@ -435,3 +438,89 @@ jobs:
remote_port: ${{ secrets.NIGHTLIES_RSYNC_PORT }}
remote_user: ${{ secrets.NIGHTLIES_RSYNC_USER }}
remote_key: ${{ secrets.NIGHTLIES_RSYNC_KEY }}
+
+
+ # Build velox with enhanced features
+ build-native-lib-enhanced:
+ runs-on: ubuntu-22.04
+ steps:
+ - uses: actions/checkout@v4
+ - name: Get Ccache
+ uses: actions/cache/restore@v4
+ with:
+ path: '${{ env.CCACHE_DIR }}'
+ key: ccache-centos7-release-default-${{github.sha}}
+ restore-keys: |
+ ccache-centos7-release-default
+ - name: Build Gluten velox third party
+ run: |
+ docker run -v $GITHUB_WORKSPACE:/work -w /work
apache/gluten:vcpkg-centos-7 bash -c "
+ df -a
+ cd /work
+ export CCACHE_DIR=/work/.ccache
+ bash dev/ci-velox-buildstatic-centos-7-enhanced-features.sh
+ ccache -s
+ mkdir -p /work/.m2/repository/org/apache/arrow/
+ cp -r /root/.m2/repository/org/apache/arrow/*
/work/.m2/repository/org/apache/arrow/
+ "
+ - name: Upload native libs
+ uses: actions/upload-artifact@v4
+ with:
+ path: ./cpp/build/releases/
+ name: velox-native-lib-enhanced-${{github.sha}}
+ retention-days: 1
+ - name: Upload Artifact Arrow Jar
+ uses: actions/upload-artifact@v4
+ with:
+ path: .m2/repository/org/apache/arrow/
+ name: velox-arrow-jar-centos-7-enhanced-${{github.sha}}
+
+ build-bundle-enhanced-package-centos8-jdk17:
+ needs: build-native-lib-enhanced
+ runs-on: ubuntu-22.04
+ container: centos:8
+ steps:
+ - uses: actions/checkout@v4
+ - name: Download All Artifacts
+ uses: actions/download-artifact@v4
+ with:
+ name: velox-native-lib-enhanced-${{github.sha}}
+ path: ./cpp/build/releases
+ - name: Download All Arrow Jar Artifacts
+ uses: actions/download-artifact@v4
+ with:
+ name: velox-arrow-jar-centos-7-enhanced-${{github.sha}}
+ path: /root/.m2/repository/org/apache/arrow/
+ - name: Setup java and maven
+ run: |
+ sed -i 's/mirrorlist/#mirrorlist/g' /etc/yum.repos.d/CentOS-* && \
+ sed -i
's|#baseurl=http://mirror.centos.org|baseurl=http://vault.centos.org|g'
/etc/yum.repos.d/CentOS-* && \
+ yum update -y && yum install -y java-17-openjdk-devel wget
+ $SETUP install_maven
+ - name: Get current date
+ id: date
+ run: echo "::set-output name=date::$(date +'%Y-%m-%d')"
+ - name: Build package for Spark
+ run: |
+ cd $GITHUB_WORKSPACE/ && \
+ export MAVEN_HOME=/usr/lib/maven && \
+ export PATH=${PATH}:${MAVEN_HOME}/bin && \
Review Comment:
`$SETUP install_maven` will set environment variable, so it seems the above
two lines are not required.
https://github.com/apache/incubator-gluten/blob/02c776f50d77ec965152b2033388bec5f27dbdd3/.github/workflows/util/setup-helper.sh#L31
##########
.github/workflows/velox_nightly.yml:
##########
@@ -435,3 +438,89 @@ jobs:
remote_port: ${{ secrets.NIGHTLIES_RSYNC_PORT }}
remote_user: ${{ secrets.NIGHTLIES_RSYNC_USER }}
remote_key: ${{ secrets.NIGHTLIES_RSYNC_KEY }}
+
+
+ # Build velox with enhanced features
+ build-native-lib-enhanced:
+ runs-on: ubuntu-22.04
+ steps:
+ - uses: actions/checkout@v4
+ - name: Get Ccache
+ uses: actions/cache/restore@v4
+ with:
+ path: '${{ env.CCACHE_DIR }}'
+ key: ccache-centos7-release-default-${{github.sha}}
Review Comment:
This will download the ccache from regular native lib build, not the
enhanced lib build. Are they quite similar? If so, it may be good to share the
ccache. Suggest adding one comment to clarify ccache for enhanced lib may be
required in the future.
##########
.github/workflows/velox_nightly.yml:
##########
@@ -435,3 +438,89 @@ jobs:
remote_port: ${{ secrets.NIGHTLIES_RSYNC_PORT }}
remote_user: ${{ secrets.NIGHTLIES_RSYNC_USER }}
remote_key: ${{ secrets.NIGHTLIES_RSYNC_KEY }}
+
+
+ # Build velox with enhanced features
+ build-native-lib-enhanced:
+ runs-on: ubuntu-22.04
+ steps:
+ - uses: actions/checkout@v4
+ - name: Get Ccache
+ uses: actions/cache/restore@v4
+ with:
+ path: '${{ env.CCACHE_DIR }}'
+ key: ccache-centos7-release-default-${{github.sha}}
+ restore-keys: |
+ ccache-centos7-release-default
+ - name: Build Gluten velox third party
+ run: |
+ docker run -v $GITHUB_WORKSPACE:/work -w /work
apache/gluten:vcpkg-centos-7 bash -c "
+ df -a
+ cd /work
+ export CCACHE_DIR=/work/.ccache
+ bash dev/ci-velox-buildstatic-centos-7-enhanced-features.sh
+ ccache -s
+ mkdir -p /work/.m2/repository/org/apache/arrow/
+ cp -r /root/.m2/repository/org/apache/arrow/*
/work/.m2/repository/org/apache/arrow/
+ "
+ - name: Upload native libs
+ uses: actions/upload-artifact@v4
+ with:
+ path: ./cpp/build/releases/
+ name: velox-native-lib-enhanced-${{github.sha}}
+ retention-days: 1
+ - name: Upload Artifact Arrow Jar
+ uses: actions/upload-artifact@v4
+ with:
+ path: .m2/repository/org/apache/arrow/
+ name: velox-arrow-jar-centos-7-enhanced-${{github.sha}}
+
+ build-bundle-enhanced-package-centos8-jdk17:
+ needs: build-native-lib-enhanced
+ runs-on: ubuntu-22.04
+ container: centos:8
+ steps:
+ - uses: actions/checkout@v4
+ - name: Download All Artifacts
+ uses: actions/download-artifact@v4
+ with:
+ name: velox-native-lib-enhanced-${{github.sha}}
+ path: ./cpp/build/releases
+ - name: Download All Arrow Jar Artifacts
+ uses: actions/download-artifact@v4
+ with:
+ name: velox-arrow-jar-centos-7-enhanced-${{github.sha}}
+ path: /root/.m2/repository/org/apache/arrow/
+ - name: Setup java and maven
+ run: |
+ sed -i 's/mirrorlist/#mirrorlist/g' /etc/yum.repos.d/CentOS-* && \
+ sed -i
's|#baseurl=http://mirror.centos.org|baseurl=http://vault.centos.org|g'
/etc/yum.repos.d/CentOS-* && \
+ yum update -y && yum install -y java-17-openjdk-devel wget
+ $SETUP install_maven
+ - name: Get current date
+ id: date
+ run: echo "::set-output name=date::$(date +'%Y-%m-%d')"
+ - name: Build package for Spark
+ run: |
+ cd $GITHUB_WORKSPACE/ && \
+ export MAVEN_HOME=/usr/lib/maven && \
+ export PATH=${PATH}:${MAVEN_HOME}/bin && \
+ mvn clean install -Pspark-3.4 -Pjava-17 -Pbackends-velox -Pceleborn
-Puniffle -Piceberg -Phudi -Pdelta -Ppaimon -DskipTests -Dmaven.source.skip
+ mvn clean install -Pspark-3.5 -Pjava-17 -Pbackends-velox -Pceleborn
-Puniffle -Piceberg -Phudi -Pdelta -Ppaimon -DskipTests -Dmaven.source.skip
+ mvn clean install -Pspark-4.0 -Pscala-2.13 -Pjava-17
-Pbackends-velox -Pceleborn -Puniffle -Piceberg -Phudi -Pdelta -Ppaimon
-DskipTests -Dmaven.source.skip
Review Comment:
Maybe, we should use `build/mvn` as Kent's WIP PR suggested?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
