jinchengchenghh commented on code in PR #11533:
URL:
https://github.com/apache/incubator-gluten/pull/11533#discussion_r2757290150
##########
backends-velox/src-iceberg/test/scala/org/apache/spark/sql/gluten/TestUtils.scala:
##########
@@ -24,7 +24,7 @@ import scala.reflect.ClassTag
object TestUtils {
- def checkExecutedPlanContains[T: ClassTag](spark: SparkSession, sqlStr:
String): Unit = {
+ def checkExecutedPlanContains[T: ClassTag](spark: SparkSession, action: =>
Unit): Unit = {
Review Comment:
Could you add a new method and keep old arguments? Most of the user may only
need to execute one sql.
##########
backends-velox/src-iceberg/test/scala/org/apache/gluten/execution/enhanced/VeloxIcebergSuite.scala:
##########
@@ -237,7 +240,7 @@ class VeloxIcebergSuite extends IcebergSuite {
|as select * from iceberg_tb1
|""".stripMargin
- TestUtils.checkExecutedPlanContains[VeloxIcebergAppendDataExec](spark,
sqlStr)
+ TestUtils.checkExecutedPlanContains[VeloxIcebergAppendDataExec](spark,
spark.sql(sqlStr))
Review Comment:
Why this line change?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
