jinchengchenghh commented on issue #11524: URL: https://github.com/apache/incubator-gluten/issues/11524#issuecomment-3840260361
Since we focus on demo TPCDS Q95 which only involves integer data type for exchange, so we reach an agreement that we will defer this discussion, this mismatch may occur in GPU fallback and exchange contains bool and timestamp. 1. Unified writer and separate reader, we can decide if the plan can execute on GPU before this stage executed, collecting some statistic from the last stage, and do some decision 2. GPU writer-> GPU reader, CPU writer -> CPU reader, decide before the plan executes in injectQueryStagePrepRule, eliminate the row by row buffer set of timestamp and bool. May decide which is better after TPCH benchmark or some tests specified for bool and timestamp. For TPCH, we should resolve all GPU fallback after Exchange. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
