jinchengchenghh commented on code in PR #11556:
URL:
https://github.com/apache/incubator-gluten/pull/11556#discussion_r2762218205
##########
cpp/velox/cudf/CudfPlanValidator.cc:
##########
@@ -36,15 +37,15 @@ bool isCudfOperator(const exec::Operator* op) {
return dynamic_cast<const velox::cudf_velox::NvtxHelper*>(op) != nullptr;
}
-}
+} // namespace
bool CudfPlanValidator::validate(const ::substrait::Plan& substraitPlan) {
auto veloxMemoryPool = gluten::defaultLeafVeloxMemoryPool();
std::vector<::substrait::ReadRel_LocalFiles> localFiles;
std::unordered_map<std::string, std::string> configValues;
std::vector<std::shared_ptr<ResultIterator>> inputs;
- std::shared_ptr<facebook::velox::config::ConfigBase> veloxCfg =
-
std::make_shared<facebook::velox::config::ConfigBase>(std::unordered_map<std::string,
std::string>());
+ std::shared_ptr<facebook::velox::config::ConfigBase> veloxCfg =
std::make_shared<facebook::velox::config::ConfigBase>(
Review Comment:
We can simplify to only transfer cudf config here for validation, to avoid
other session config causing fallback, we may send the veloxCfg from
VeloxRuntime to here in the future
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
