acvictor opened a new pull request, #11558: URL: https://github.com/apache/incubator-gluten/pull/11558
## What changes are proposed in this pull request? When Spark constant-folds the `CreateMap` expression in `raise_error` calls, the expression becomes a `Literal` containing `MapData` instead of a `CreateMap` with literal children. The previous implementation couldn't extract the error message from this optimized form, causing fallback. This fix ensures proper handling. I have updated test `SPARK-52684` which previously would fallback but is now executed in Gluten and hence throws a `SparkException` (wrapping `GlutenException` instead of `SparkRuntimeException` ``` org.apache.gluten.exception.GlutenException: org.apache.gluten.exception.GlutenException: Exception: VeloxUserError Error Source: USER Error Code: INVALID_ARGUMENT Reason: SPARK-52684 Retriable: False DisplayReason: False Context: Top-level Expression: raise_error(SPARK-52684:VARCHAR) Function: setStatus File: /root/velox/velox/expression/EvalCtx.cpp Line: 184 Stack trace: # 0 _ZN8facebook5velox7process10StackTraceC1Ei # 1 _ZN8facebook5velox14VeloxExceptionC2EPKcmS3_St17basic_string_viewIcSt11char_traitsIcEES7_S7_S7_bbNS1_4TypeES7_ # 2 _ZN8facebook5velox6detail14veloxCheckFailINS0_14VeloxUserErrorERKNSt7__cxx1112basic_stringIcSt11char_traitsIcESaIcEEEEEvRKNS1_18VeloxCheckFailArgsET0_ # 3 _ZN8facebook5velox4exec7EvalCtx9setStatusEiRKNS0_6StatusE # 4 _ZNK8facebook5velox17SelectivityVector15applyToSelectedIZNS0_4exec7EvalCtx22applyToSelectedNoThrowIZNKS3_21SimpleFunctionAdapterINS0_4core9UDFHolderINS0_9functions8sparksql18RaiseErrorFunctionINS3_10VectorExecEEESC_NS0_12UnknownValueENS0_15ConstantCheckerIJNS0_7VarcharEEEEJSG_EEEE7iterateIJNS3_20ConstantVectorReaderISG_EEEEEvRNSJ_12ApplyContextEDpRT_EUlT_E3_ZNS4_22applyToSelectedNoThrowIST_EEvRKS1_SS_EUlSS_E_EEvSW_SS_T0_EUlSS_E_EEvSS_ # 5 _ZNK8facebook5velox4exec21SimpleFunctionAdapterINS0_4core9UDFHolderINS0_9functions8sparksql18RaiseErrorFunctionINS1_10VectorExecEEES8_NS0_12UnknownValueENS0_15ConstantCheckerIJNS0_7VarcharEEEEJSC_EEEE5applyERKNS0_17SelectivityVectorERSt6vectorISt10shared_ptrINS0_10BaseVectorEESaISM_EERKSK_IKNS0_4TypeEERNS1_7EvalCtxERSM_ # 6 _ZN8facebook5velox4exec4Expr13applyFunctionERKNS0_17SelectivityVectorERNS1_7EvalCtxERSt10shared_ptrINS0_10BaseVectorEE # 7 _ZN8facebook5velox4exec4Expr19evalFlatNoNullsImplERKNS0_17SelectivityVectorERNS1_7EvalCtxERSt10shared_ptrINS0_10BaseVectorEEPKNS1_7ExprSetE # 8 _ZN8facebook5velox4exec7ExprSet4evalEiibRKNS0_17SelectivityVectorERNS1_7EvalCtxERSt6vectorISt10shared_ptrINS0_10BaseVectorEESaISB_EE # 9 _ZN8facebook5velox4exec13FilterProject7projectERKNS0_17SelectivityVectorERNS1_7EvalCtxE # 10 _ZN8facebook5velox4exec13FilterProject9getOutputEv # 11 _ZZN8facebook5velox4exec6Driver11runInternalERSt10shared_ptrIS2_ERS3_INS1_13BlockingStateEERS3_INS0_9RowVectorEEENKUlvE7_clEv # 12 _ZN8facebook5velox4exec6Driver11runInternalERSt10shared_ptrIS2_ERS3_INS1_13BlockingStateEERS3_INS0_9RowVectorEE # 13 _ZN8facebook5velox4exec6Driver4nextEPN5folly10SemiFutureINS3_4UnitEEERPNS1_8OperatorERNS1_14BlockingReasonE # 14 _ZN8facebook5velox4exec4Task4nextEPN5folly10SemiFutureINS3_4UnitEEE # 15 _ZN6gluten24WholeStageResultIterator4nextEv # 16 Java_org_apache_gluten_vectorized_ColumnarBatchOutIterator_nativeHasNext # 17 0x00007bf6fc8459c7 ``` ## How was this patch tested? UT in CI ## Was this patch authored or co-authored using generative AI tooling? No -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
